Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] main from kubeflow:main #28

Merged
merged 10 commits into from
Mar 26, 2024
Merged

[pull] main from kubeflow:main #28

merged 10 commits into from
Mar 26, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Mar 18, 2024 •
edited
Loading

See Commits and Changes for more details.

Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

dependabot bot and others added 6 commits March 12, 2024 07:26
@dependabot
build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (#37)
43efbe9 
Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps): bump google.golang.org/grpc from 1.62.0 to 1.62.1 (#38)
67d9e4d 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.0 to 1.62.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.62.0...v1.62.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@isinyaaa @tarilabs
OAS: fix minor issues and bump version (#29)
962c78d 
* OAS: fixup ID -> Id in parameter names

... to preserve camelCase.

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* fix REST api to use ModelVersionUpdate in PATCH method

Signed-off-by: Matteo Mortari <[email protected]>

* bump OAS version to v1alpha3

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Isabella Basso do Amaral <[email protected]>
Signed-off-by: Matteo Mortari <[email protected]>
Co-authored-by: Matteo Mortari <[email protected]>
@tarilabs
add testing of KF MR Manifests (#36)
aeeffc0 
Signed-off-by: Matteo Mortari <[email protected]>
@dependabot
build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 in…
cfb4712 
… /csi (#40)

Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tarilabs
add dockerhub container registry use (#41)
c9bdfc2 
... replaces quay.io use in CI/CD/container-registry-use
which was available originally through quay.io

Signed-off-by: Matteo Mortari <[email protected]>
@openshift-ci openshift-ci bot requested review from dhirajsb and nehachopra27 March 18, 2024 19:30
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pull[bot]
Once this PR has been reviewed and has the lgtm label, please assign rareddy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 18, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Mar 19, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Mar 21, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Mar 21, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Mar 22, 2024
@isinyaaa
Construct proper S3 URIs on register_model (#39)
1ef7b3c 
* py: provide default URI builder for S3 in register_model

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* py: provide overloads for type-checking register_model

Signed-off-by: Isabella Basso do Amaral <[email protected]>

* py: verify overload signatures at runtime

Signed-off-by: Isabella Basso do Amaral <[email protected]>

---------

Signed-off-by: Isabella Basso do Amaral <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tonyxrmdavidson pushed a commit to tonyxrmdavidson/model-registry that referenced this pull request Mar 22, 2024
@rkubis
New(robot): Environment variable TEST_PORT for setting test port (ope…
ed52ec7 
…ndatahub-io#28)

Signed-off-by: Radim Kubis <[email protected]>
@pull pull bot removed the needs-rebase label Mar 23, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pull pull bot removed the needs-rebase label Mar 24, 2024
@tarilabs
add Kustomize 5.2.1 in Kind GHA testing (#43)
784c9fb 
* add Kustomize 5.2.1 in Kind GHA testing

Signed-off-by: Matteo Mortari <[email protected]>

* fix GHA syntax for dependent env

Signed-off-by: Matteo Mortari <[email protected]>

* use kustomize install binary instead of dedicated GHA step

Signed-off-by: Matteo Mortari <[email protected]>

* kustomize seems installed by default in GHA

Signed-off-by: Matteo Mortari <[email protected]>

---------

Signed-off-by: Matteo Mortari <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tarilabs
fix: query param might be empty string value (#49)
2245b4b 
...handle gin-generated code by openapi-codegen internally,
so to make propert string ptr semantic as expected by core lib,
as a query param might not even be passed during requests

Signed-off-by: Matteo Mortari <[email protected]>
@pull pull bot removed the needs-rebase label Mar 25, 2024
@dependabot
build(deps): bump github.com/docker/docker from 24.0.7+incompatible t…
246d8e7 
…o 24.0.9+incompatible (#47)

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.7+incompatible to 24.0.9+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v24.0.7...v24.0.9)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit cbb2751 into opendatahub-io:main Mar 26, 2024
1 check failed
@tarilabs
Copy link
Member

this was actually "done" as part of #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhirajsb dhirajsb Awaiting requested review from dhirajsb

@nehachopra27 nehachopra27 Awaiting requested review from nehachopra27

Assignees
No one assigned
Labels
merge-conflict Resolve conflicts manually needs-rebase tide/merge-method-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-merge-robot @tarilabs @isinyaaa